Let's introduce a view and route for internal users when looking at the Eligible Stays app.
AC
With the internal view for Eligible Stays, IUs should be able to:
View all properties in the current table view regardless if they are eligible or not
When hovering over an ineligible row, IUs should see a button appear on the right sight of the row that says "Override"
Scenarios where admins can overrride:
Scenarios where admins cannot override (most are unlikely to happen & are protections against bad data):
[team member] please pick up the after completing OUT-3230
[team member] Very glad that this is being planned. This should help IU rely less on us. But I'd like to flag about possible regression: Are we linking to this app from anywhere eg. Message to IU or CU? In which case adding a new app as custom app would have new id right?
[team member] To allow IU to override the eligibility I want to first understand what kind of inelegibiliy do we want to override?
export const ineligibilityReasonLabels: Record<IneligibilityReason, string> = {
[IneligibilityReason.PENDING_BOOKING]: 'Pending booking',
[IneligibilityReason.INSUFFICIENT_BOOKINGS]: 'Less than 5 bookings',
[IneligibilityReason.ON_PAUSE]: 'On pause',
[IneligibilityReason.SLH_NULL]: 'SLH status unknown',
[IneligibilityReason.SLH_BLOCKED_THIS_YEAR]: 'SLH — already shopped this year',
[IneligibilityReason.SHOPPED_WITHIN_6_MONTHS]: 'Shopped within last 6 months',
};
There certainly are other conditions, but I think those are valid reason that should not be overridded.
[IneligibilityReason.MISSING_NAME]: 'Missing hotel name',
[IneligibilityReason.MISSING_COUNTRY]: 'Missing country',
[IneligibilityReason.MISSING_MARKET]: 'Missing market',
[IneligibilityReason.INVALID_COLLECTION]: 'Invalid collection type',
[IneligibilityReason.NO_APPENDIX_SUBMISSION]: 'No appendix form submitted',
[IneligibilityReason.MISSING_COLLECTION]: 'Missing collection type on submission',
[IneligibilityReason.APPENDIX_NOT_APPROVED]: 'Appendix form not approved',
My plan here is to set the bookingForcefullyEnabledAt timestamp which will be set to null after another request.
[team member] what does "SLH status unknown" mean? Do we prevent a hotel from appearing if we aren't sure if it is or is not apart of the SLH group?
The grouping you proposed makes sense, will confirm with C1
Ok confirme with C1. They requested a couple of changes, see the final grouping I added to this ticket description
[team member] Can we delete the override for the property when it is approved again. eg. We override On Pause for example, And user then makes a booking, can we remove the override in that case. Same for other overrides like 6 months booking. Otherwise the property will always be bookable under 6 month. What do you think? IU has to override it after approval if they want to make it eligible again.
Hmm yes. That makes sense to me, meaning this override generally is just a one time override and expires after the next booking. Good callout